firebase-admin-node icon indicating copy to clipboard operation
firebase-admin-node copied to clipboard

imageUrl with special characters, are not allowed in firebase messaging. But there exists a lots of image urls with different special characters.

Open pavanyekabote opened this issue 4 years ago • 4 comments

Environment:

  • Operating System Version: Ubuntu 20.04.2 LTS
  • Firebase SDK version: 9.4.1
  • Firebase Product: messaging (fcm)
  • Node.js version: v12.21.0
  • NPM Version: 6.14.11

Steps to reproduce:

  • Following code is in typescript.
import * as admin from 'firebase-admin';

let message: admin.messaging.MulticastMessage = {
    tokens: ["<fcmtokens>"],
    notification: {
        title: "This is a test notification on fcm",
        body: "This notification is to check if image with specials chars can be sent in fcm notification",
        imageUrl: "https://s.yimg.com/uu/api/res/1.2/8e4p0MNjKRtV25O3t_qSMw--~B/aD00MjU7dz04MDA7YXBwaWQ9eXRhY2h5b24-/https://media.zenfs.com/en/nextshark_articles_509/287cce64e3a1cd49446e8751b89262ef"
    }
}
admin.messaging().sendMulticast(message)
    .then((response: admin.messaging.BatchResponse) => {
        console.log("Message has been sent...");
    })
    .catch((error: any) => {
        console.log(error); 
        // This notification throws here, and flow comes in this section 
        // Error is "notification.imageUrl must be a valid URL string"
    });

As we see, the above example, the imageUrl has multiple special characters, still it is an URL which can surely load an image. But, firebase admin doesn't accept this.

Hope to see some upgrades in the pattern checking rules of imageUrl.

Thanks.

pavanyekabote avatar Apr 01 '21 10:04 pavanyekabote

It's not really a matter of special characters. Our existing path regex doesn't allow empty path segments, and the // in the middle of the path is interpreted as an empty path segment. Will see what we can do about that.

hiranya911 avatar Apr 01 '21 18:04 hiranya911

These days, the URLs are becoming too dynamic... However, thanks for " Will see what we can do about that.". Really grateful if a viable solution is implemented.

Thanks.

pavanyekabote avatar Apr 02 '21 05:04 pavanyekabote

any update on this?

vulcantechsdevs avatar Jan 04 '24 01:01 vulcantechsdevs

How am I supposed to specify an image if I can't use a "/" ??

Quaybe avatar Jan 29 '24 17:01 Quaybe