firebase-admin-go icon indicating copy to clipboard operation
firebase-admin-go copied to clipboard
verified publisher icon firebase

Add LinkDomain to ActionCodeSettings

Open graeme-verticalscope opened this issue 10 months ago • 2 comments

Discussion

Add the LinkDomain field to the ActionCodeSettings struct, this new field enables migrating off of firebase dynamic links, which is deprecated and will be unsupported soon.

See issue https://github.com/firebase/firebase-admin-go/issues/681

Testing

Unit test is updated to check that linkDomain is set correctly in the action code settings map.

I haven't tested the backend service to confirm it will accept this new parameter, but it looks like this should be the only change required, since the nodeJS SDK already includes the linkDomain field.

API Changes

N/A

graeme-verticalscope avatar Apr 09 '25 15:04 graeme-verticalscope

Could someone take a look at this PR? (and related issue)

Firebase dynamic links will be shutdown on Aug 25, and I am hoping to be migrated off of dynamic links by the end of April, to ensure a comfortable buffer time before the shutdown deadline.

graeme-verticalscope avatar Apr 14 '25 18:04 graeme-verticalscope

Anyone able to look at this please? The deadline is approaching

jackhopner avatar May 30 '25 04:05 jackhopner

Less then 2 months until dynamic links are shutdown. Note that this change does work :) I think it should really be in the official SDK before you shutdown dynamic links.

graeme-verticalscope avatar Jun 27 '25 13:06 graeme-verticalscope

Closing this, since there is more recent activity on #703

graeme-verticalscope avatar Jul 22 '25 20:07 graeme-verticalscope