FirebaseUI-iOS icon indicating copy to clipboard operation
FirebaseUI-iOS copied to clipboard

FirebaseGoogleAuthUI no longer needs to be static_framework

Open kustra opened this issue 3 years ago • 0 comments

Step 1: Are you in the right place?

The issue is concerning FirebaseGoogleAuthUI.podspec. It is a follow-up of this PR.

The GoogleSignIn pod is open source since 6.0.0. It is no longer built as a static framework, so there's no need for FirebaseGoogleAuthUI to be a static framework either. Here's the relevant line in the podspec of the last 5.x version: https://github.com/CocoaPods/Specs/blob/master/Specs/d/4/0/GoogleSignIn/5.0.2/GoogleSignIn.podspec.json#L40 It's no longer present in 6.0.0: https://github.com/CocoaPods/Specs/blob/master/Specs/d/4/0/GoogleSignIn/6.0.0/GoogleSignIn.podspec.json

FirebaseGoogleAuthUI is using GoogleSignIn ~6.0 right now: https://github.com/firebase/FirebaseUI-iOS/blob/master/FirebaseGoogleAuthUI.podspec#L25

Step 2: Describe your environment

  • Objective C or Swift: Swift
  • iOS version: iOS 13
  • Firebase SDK version: 8.8.0
  • FirebaseUI version: 12.2.0
  • CocoaPods Version: 1.11.3

Step 3: Describe the problem:

Steps to reproduce:

Include the FirebaseGoogleAuthUI pod in my project, e.g.

pod 'FirebaseUI', '~> 12.0', :subspecs => ['Auth', 'Email', 'Facebook', 'OAuth', 'Google']

Observed Results:

FirebaseGoogleAuthUI is built as a static framework.

Expected Results:

FirebaseGoogleAuthUI is built as a dynamic framework.

kustra avatar Jul 11 '22 16:07 kustra