git-proxy icon indicating copy to clipboard operation
git-proxy copied to clipboard

chore: upgrade admin dashboard ui to react 18

Open lwhiteley opened this issue 1 year ago • 3 comments

Changes:

  • upgrade to react 18
  • upgrade to mui v6
    • increase specificity of app styles to override mui component styles
  • replace react-html-parser with html-react-parser

Notes:

After an audit of the dependencies of this project, it was determined that react and a few libraries were outdated.

one of the dependencies preventing an upgrade is react-html-parser . it has a peer dependency of react 16. A successor of the package is html-react-parser

However, there is no storybook setup in the project or a way to test this easily.

How can i get diff data passed to this component to test in isolation or Can someone give steps to arrive at this view to test it in the UI to verify it works?

I also see that there are cypress tests but i dont believe this view is covered yet

old package: https://www.npmjs.com/package/react-html-parser proposed package: https://www.npmjs.com/package/html-react-parser


TODOs:

  • [x] fix ui styling glitches
    • increase css specificity
  • [x] fix dep check

Please test thoroughly Let me know if i missed something

lwhiteley avatar Oct 06 '24 11:10 lwhiteley

Deploy Preview for endearing-brigadeiros-63f9d0 ready!

Name Link
Latest commit 742409a30aa81a6ddfd744190fe5d5238edab7ed
Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/6723ebdae6339500087a986c
Deploy Preview https://deploy-preview-740--endearing-brigadeiros-63f9d0.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 06 '24 11:10 netlify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.23%. Comparing base (39dd45c) to head (742409a). Report is 489 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #740   +/-   ##
=======================================
  Coverage   60.23%   60.23%           
=======================================
  Files          47       47           
  Lines        1647     1647           
=======================================
  Hits          992      992           
  Misses        655      655           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Oct 06 '24 11:10 codecov[bot]

@lwhiteley - happy for me to start reviewing?

JamieSlome avatar Oct 11 '24 20:10 JamieSlome

closing for for now..

if needed the blueprint to get it done is here and in the description

lwhiteley avatar May 28 '25 08:05 lwhiteley