making COOKIE_SECRET an env var

Open kulp006 opened this issue 1 year ago • 5 comments

make COOKIE_SECRET an env var instead of checking in proxy.config.json

https://github.com/finos/git-proxy/blob/fd638483c70bc84f3f9cedb6e10f8d0a18bafacf/proxy.config.json#L3

Aug 14 '24 14:08 kulp006

Thanks for creating the issue @kulp006. Can you explain what your requirement is or why you think this should be the case?

Aug 15 '24 17:08 JamieSlome

I am guessing the recommendation to use ENV variable is to make sure that new installations changes it. I can work on it if the request is still valid.

Oct 03 '24 06:10 coderhs

Can you assign me this task?

Oct 22 '24 20:10 Aditya-PS-05

@Aditya-PS-05 - sure!

Oct 22 '24 20:10 JamieSlome

@JamieSlome , Please review my pr.

Oct 26 '24 11:10 Aditya-PS-05