EntityFrameworkCore.TemporalTables icon indicating copy to clipboard operation
EntityFrameworkCore.TemporalTables copied to clipboard

Dependency on .net standard 2.1

Open ury opened this issue 6 years ago • 6 comments

Hi, Is the dependency on .net standard 2.1 and not 2.0 mandatory? My client project (Blazor) has a strong dependency on .net standard 2.0 and therefore cannot reference the DAL project containing the TemporalTables package. Thanks, Ury

ury avatar Nov 23 '19 16:11 ury

Hi, The library relies entirely on Entity Framework Core 3.0 and requires using .net standard 2.1 library. It is described here: https://docs.microsoft.com/en-us/ef/core/what-is-new/ef-core-3.0/breaking-changes#netstandard21

findulov avatar Nov 23 '19 19:11 findulov

Thanks. Fortunately, this limitation was removed (at least for the time being) in .NET Core 3.1 (currently in prerelease). I tested it and it works. May I create a .NET Standard 2.0 / Core 3.1 fork?

ury avatar Nov 24 '19 06:11 ury

Sure, go ahead!

findulov avatar Nov 24 '19 15:11 findulov

@findulov Hi, thanks for this project, it's exactly what I was looking for but sadly am stuck on dotnetcore 3.1/nestandard 2.1 for at least another year and a half. Would you reconsider upgrading this project to dotnet 5 and instead switching it back to netstandard 2.1? The latest EF core (5.0.5 right now) has a dependency on netstandard 2.1, so the restriction to only support dotnet 5 is not really necessary and potentially reduces the amount of potential adopters for no gain.

I can create my own fork of course and do it there, but it's just so much easier to just use an already existing package.

Driedas avatar Apr 23 '21 13:04 Driedas

Hi, thanks for using the library. I could update it but I haven't found available time to investigate the new netstandard 2.1 support in .NET 5.0 and I'm afraid not to break something by applying the changes.

It could take me a few days to get this done and if you need this immediately, feel free to fork it right now.

findulov avatar Apr 25 '21 01:04 findulov

I understand your concerns, however according to the dotnet compatibility matrix (https://docs.microsoft.com/en-us/dotnet/standard/net-standard) both core 3.1 and 5.0 support netstandard 2.1 equally. I will use a fork for now and will switch to your nuget package if you decide to roll the switch back. Thanks!

Driedas avatar Apr 25 '21 17:04 Driedas