sample-notebooks icon indicating copy to clipboard operation
sample-notebooks copied to clipboard
verified publisher icon finbourne

SE-2238: Added Legal Entity Notebook

Open lorenzdec opened this issue 3 years ago • 3 comments

Pull Request Checklist

  • [x] Changes follow the style guide
  • [ ] Tests pass
  • [x] Raised the PR against the develop branch

Description of the PR

Describe the code changes for the reviewers, explain the solution you have provided and how it fixes the issue

lorenzdec avatar Nov 21 '22 17:11 lorenzdec

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

review-notebook-app[bot] avatar Nov 21 '22 17:11 review-notebook-app[bot]

This is good to go, one further thing we could do is to demonstrate the features to paint on related entity properties - happy if this is done under a separate MR

steco avatar Nov 21 '22 18:11 steco

/LGTM

rizwansaeed avatar Nov 22 '22 16:11 rizwansaeed

Closing as done in https://github.com/finbourne/sample-notebooks/blob/master/examples/use-cases/portfolio-construction/Legal%20Entity-Instrument%20Relationships.ipynb.disable , but needs enabling

hanialsibai avatar May 29 '24 11:05 hanialsibai