sample-notebooks icon indicating copy to clipboard operation
sample-notebooks copied to clipboard

DEV-11476: Recover Orders With Holdings Notebook

Open timbarrass-finbourne opened this issue 3 years ago • 1 comments

This reverts commit 46c15d6a772cfea03de64a97b75f124db44385c6, and returns the GetHoldingsWithOrders test notebook to the sample-notebooks set

Pull Request Checklist

  • [ ] Changes follow the style guide
  • [ ] Tests pass
  • [ ] Raised the PR against the develop branch

Description of the PR

I wrote this notebook a little while back to demonstrate the use of (and experiment with problems with) the GetHoldingsWithOrders LUSID endpoint. It was removed from the repo in SENG-43 because of performance issues in the pipeline. Since then we've added DEI support for the entities, and worked on this endpoint's performance, so we should be in a position to get it running again.

timbarrass-finbourne avatar Jul 21 '22 14:07 timbarrass-finbourne

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Closing as already merged in separate PR https://github.com/finbourne/sample-notebooks/blob/master/examples/use-cases/orders-management/Incorporating%20live%20orders%20into%20your%20holdings%20view.ipynb

hanialsibai avatar May 23 '24 08:05 hanialsibai