finch icon indicating copy to clipboard operation
finch copied to clipboard

streaming with Monix's Iterant

Open alexeygorobets opened this issue 7 years ago • 3 comments

solve #1078

alexeygorobets avatar Mar 08 '19 18:03 alexeygorobets

Codecov Report

Merging #1098 into master will decrease coverage by 0.57%. The diff coverage is 68.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1098      +/-   ##
==========================================
- Coverage   81.04%   80.46%   -0.58%     
==========================================
  Files          54       55       +1     
  Lines        1018     1034      +16     
  Branches       59       55       -4     
==========================================
+ Hits          825      832       +7     
- Misses        193      202       +9
Impacted Files Coverage Δ
monix/src/main/scala/io/finch/monix/package.scala 68.75% <68.75%> (ø)
core/src/main/scala/io/finch/Input.scala 91.8% <0%> (-8.2%) :arrow_down:
core/src/main/scala/io/finch/Endpoint.scala 73.14% <0%> (+0.57%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f3d374c...799dc54. Read the comment docs.

codecov-io avatar Mar 08 '19 18:03 codecov-io

Hey, @alexeygorobets! Can you rebase your branch and adopt a cancelation logic similar to #1082?

vkostyukov avatar Mar 13 '19 23:03 vkostyukov

I think this would have to wait for CE3 support in Monix: https://github.com/monix/monix/pull/1533

joroKr21 avatar Aug 12 '22 11:08 joroKr21