core icon indicating copy to clipboard operation
core copied to clipboard

data model options

Open joneit opened this issue 8 years ago • 2 comments

@Dwaynekj Hey DJ, While refining/updating issue #614 (v3 prep), I came across your change to the calling signature of the data source constructor, which I’m sure you recall was in support of group view's tree column.

You added two parameters to the constructor. While pertinent to the current “standard” datamodel, it is meaningless to a generic “black box” datamodel, which should not need to support those parameters.

I propose changing it to a generic options object. I'll post a PR.

cc:@dcchuck

joneit avatar Nov 14 '17 21:11 joneit

Ok, I'll await the PR

Dwaynekj avatar Nov 14 '17 22:11 Dwaynekj

@Dwaynekj Change of plan: I'm going to submit this today as a stand-alone PR to facilitate testing and review. (Moving away from large PRs.)

joneit avatar Dec 11 '17 14:12 joneit