Files icon indicating copy to clipboard operation
Files copied to clipboard

Bug: Creating folder in non-root path of SMB device will create multiple folders

Open jh961202 opened this issue 3 years ago • 3 comments

Description

When creating a folder with any name in a SMB device ( say, Z:\ ) and in non-root path ( say, Z:\Test ), the same action will be done 3 times including the initial one for no reason. This WON'T happen on the SMB device's root path ( say, Z:\ ), nor in local drives on the PC.

https://user-images.githubusercontent.com/8479301/182029169-017fa4ba-00b5-49e5-9191-c10a059894e7.mp4

Requirements

  • Only one folder should be created

Steps To Reproduce

  1. Attach one or more SMB device using "Map a network drive" and open it with Files
  2. Create a folder on the root path of that drive - notice that until this step everything seemed normal
  3. Enter the newly-created folder, and create any new folder
  4. See the error as shown in the video in the description

Files Version

Version: 2.3.3.0 OS Version: 10.0.22000.832

Windows Version

Windows 11 21H2 22000.832

Relevant Assets/Logs

debug.log

2022-07-31 21:22:37.7887|INFO|OnLaunched|App launched. Prelaunch: False
2022-07-31 21:22:38.0677|INFO|GetDrivesAsync|Drive added: C:\, Fixed
2022-07-31 21:22:38.1107|INFO|GetDrivesAsync|Drive added: D:\, Fixed
2022-07-31 21:22:38.1377|INFO|GetDrivesAsync|Drive added: E:\, Fixed
2022-07-31 21:22:38.1667|INFO|GetDrivesAsync|Drive added: F:\, Removable
2022-07-31 21:22:38.1947|INFO|GetDrivesAsync|Drive added: Z:\, Network
2022-07-31 21:22:38.5847|INFO|UpdateDrivesAsync|Adding cloud provider "OneDrive" mapped to C:\Users\jh961\OneDrive
2022-07-31 21:22:39.6287|INFO|CheckForUpdates|STORE: Checking for updates...
2022-07-31 21:22:39.9607|INFO|IsRunningOnArm|Running on ARM: False
2022-07-31 21:28:13.2927|INFO|OnLaunched|App launched. Prelaunch: False
2022-07-31 21:28:13.5397|INFO|GetDrivesAsync|Drive added: C:\, Fixed
2022-07-31 21:28:13.5817|INFO|GetDrivesAsync|Drive added: D:\, Fixed
2022-07-31 21:28:13.6107|INFO|GetDrivesAsync|Drive added: E:\, Fixed
2022-07-31 21:28:13.6387|INFO|GetDrivesAsync|Drive added: F:\, Removable
2022-07-31 21:28:13.6707|INFO|GetDrivesAsync|Drive added: Z:\, Network
2022-07-31 21:28:13.7667|INFO|UpdateDrivesAsync|Adding cloud provider "OneDrive" mapped to C:\Users\jh961\OneDrive
2022-07-31 21:28:14.8616|INFO|CheckForUpdates|STORE: Checking for updates...
2022-07-31 21:29:09.7619|INFO|OnLaunched|App launched. Prelaunch: False
2022-07-31 21:29:10.0119|INFO|GetDrivesAsync|Drive added: C:\, Fixed
2022-07-31 21:29:10.0439|INFO|GetDrivesAsync|Drive added: D:\, Fixed
2022-07-31 21:29:10.0769|INFO|GetDrivesAsync|Drive added: E:\, Fixed
2022-07-31 21:29:10.1039|INFO|GetDrivesAsync|Drive added: F:\, Removable
2022-07-31 21:29:10.1309|INFO|GetDrivesAsync|Drive added: Z:\, Network
2022-07-31 21:29:10.2269|INFO|UpdateDrivesAsync|Adding cloud provider "OneDrive" mapped to C:\Users\jh961\OneDrive
2022-07-31 21:29:11.2389|INFO|CheckForUpdates|STORE: Checking for updates...
2022-07-31 21:29:12.7227|INFO|IsRunningOnArm|Running on ARM: False
2022-07-31 21:46:25.2167|INFO|OnLaunched|App launched. Prelaunch: False
2022-07-31 21:46:25.7010|INFO|UpdateDrivesAsync|Adding cloud provider "OneDrive" mapped to C:\Users\jh961\OneDrive
2022-07-31 21:47:32.0728|INFO|OnLaunched|App launched. Prelaunch: False
2022-07-31 21:47:32.3518|INFO|GetDrivesAsync|Drive added: C:\, Fixed
2022-07-31 21:47:32.3938|INFO|GetDrivesAsync|Drive added: D:\, Fixed
2022-07-31 21:47:32.4298|INFO|GetDrivesAsync|Drive added: E:\, Fixed
2022-07-31 21:47:32.4688|INFO|GetDrivesAsync|Drive added: F:\, Removable
2022-07-31 21:47:32.4988|INFO|GetDrivesAsync|Drive added: Z:\, Network
2022-07-31 21:47:32.5918|INFO|UpdateDrivesAsync|Adding cloud provider "OneDrive" mapped to C:\Users\jh961\OneDrive
2022-07-31 21:47:33.7698|INFO|CheckForUpdates|STORE: Checking for updates...

No explicit revelant log was recorded in debug_fulltrust.log when the bug was reproduced

jh961202 avatar Jul 31 '22 13:07 jh961202

Same problem

XTorLukas avatar Aug 20 '22 09:08 XTorLukas

Same happens in 2.3.11.0 Also happens when not mapped to a drive, just browsing a share.

ekdahl avatar Aug 30 '22 08:08 ekdahl

User on Discord reporting same issue when pasting files and folders to SMB.

gave92 avatar Sep 09 '22 17:09 gave92

Does this still occur? I can't reproduce it.

hishitetsu avatar Feb 10 '23 10:02 hishitetsu

In version 2.3.12.0, for which the bug was reported, I could reproduce it directly In the current preview version it seems to work as expected

Version 2.3.12.0

https://user-images.githubusercontent.com/56681014/226952742-ba1d98d9-38a4-4760-b197-9810272e79ee.mp4

Version 2.4.55.0

https://user-images.githubusercontent.com/56681014/226953421-7b06fc1d-15ec-42f0-9850-be7a2309e950.mp4

marcofranzen99 avatar Mar 22 '23 15:03 marcofranzen99

Should this be closed and unpinned?

Josh65-2201 avatar Apr 14 '23 13:04 Josh65-2201

Note that the issue specifies "in non-root path", the video appears to be testing in the root only.

gave92 avatar Apr 14 '23 18:04 gave92

Note that the issue specifies "in non-root path", the video appears to be testing in the root only.

I think I also tested it for non-root paths at that time but didn't include it in the video.

But to be sure I just tested it again and noticed that it is also reproducible in Windows File Explorer if you have the network share open in the old version of Files. If the network share is open in the current version of Files, it is not a problem.

Note: I don't use networks shares a lot, so I can't tell if the bug doesn't occur at all anymore, but at least it is no longer easy to reproduce.

https://user-images.githubusercontent.com/56681014/232225480-9978f923-7467-40d1-8266-e1a2242e6fbb.mp4

marcofranzen99 avatar Apr 15 '23 13:04 marcofranzen99

@jh961202 can you check if this is still an issue?

yaira2 avatar Apr 30 '23 15:04 yaira2

@jh961202 we can't repro this issue anymore but if it's still happening on your device, please let us know and we'll reopen this issue.

yaira2 avatar May 21 '23 19:05 yaira2