Problem creating files when typing the name in Chinese

[KingRayCao]

Description

When I try to create a folder or file and try to type the name in Chinese, I can't create it immediately(the button below remains grey.). Rather, I have to delete one charactor to make the ‘create’ button available.

Steps To Reproduce

No response

Expected behavior

I can directly create the file without deleting a charactor.

Files Version

Version: 2.3.3.0 OS Version: 10.0.22000.795

Windows Version

Windows 11 21H2 22000.795

Relevant Assets/Logs

[yaira2]

I think it has to do with the fact that you aren't typing the name into the text box. Does it work if you type the text directly?

On our end, this can be resolved by adding a text changed event.

[Octoowner88]

This has to do don't write the code write actual text

[KingRayCao]

Well, typing in English works totally fine, for the text is directly typed in. I've also discovered that if you first type in some Chinese charactors, and then a space, the button will become available. Besides, if you paste Chinese charactors into the text box, the button is available

[FkLalita]

add a text change event

[Antony-Jia]

I met same question and I'll type space to fix it

[andrewruales]

Is this still an issue? I am new to open source but I would like to try and tackle this issue!

[Antony-Jia]

Yes, the problem still exists

[andrewruales]

Any advice for where I could find this issue in code?

[Antony-Jia]

I thought ` //Create file based on dialog result (ReturnResult Status, IStorageItem Item) created = (ReturnResult.Failed, null); switch (itemType) { case AddItemDialogItemType.Folder: userInput = !string.IsNullOrWhiteSpace(userInput) ? userInput : "NewFolder".GetLocalizedResource(); created = await associatedInstance.FilesystemHelpers.CreateAsync( StorageHelpers.FromPathAndType(PathNormalization.Combine(currentPath, userInput), FilesystemItemType.Directory), true); break;

            case AddItemDialogItemType.File:
                userInput = !string.IsNullOrWhiteSpace(userInput) ? userInput : itemInfo?.Name ?? "NewFile".GetLocalizedResource();
                created = await associatedInstance.FilesystemHelpers.CreateAsync(
                    StorageHelpers.FromPathAndType(PathNormalization.Combine(currentPath, userInput + itemInfo?.Extension), FilesystemItemType.File),
                    true);
                break;
        }`

may not can't tell if it's over when met special characters

[andrewruales]

Awesome, which file should I make this addition to?

[yaira2]

@andrewruales this issue is a result of custom logic that handles unlocking the create button when input is entered, should be pretty simple to fix.

[jiejasonliu]

@yaira2 I actually can't reproduce this; was this maybe unintentionally fixed? could also just be my machine...