Files icon indicating copy to clipboard operation
Files copied to clipboard

Feature: Focus existing tab instead of creating duplicate when opening from external process

Open boysent opened this issue 4 years ago • 7 comments

Description

Opening a folder from an external link (e.g. download from a browser) will open a second tab of the same folder instead of re-using the first instance of the tab. This occurs with the download folder at a minimum

Steps To Reproduce

  1. Download file from Chrome.
  2. Click to open downloads folder from Chrome
  3. New Downloads folder tab is opened in Files.
  4. Repeating steps 1-3, creates a new Downloads tab instead of re-using and activating the existing Downloads tab already in Files.

Expected behavior

Expected Downloads folder tab to be used instead of a second tab for the same folder being opened.

Files Version

Version: 2.0.34.0

Windows Version

OS Version: 10.0.22000.318

Relevant Assets

No response

boysent avatar Nov 15 '21 14:11 boysent

It's the same behavior for any folder being opened externally. I don't think it make sense to change it just for the download since that makes a consistent issue. you can simply just close the other tab and/or don't open it in the first place. I'm sure there's also complications adding this in code since files wont know why the other tabs are open from the user.

Josh65-2201 avatar Nov 15 '21 17:11 Josh65-2201

Thanks for the quick response. I didn't mean to imply that the download folder is unique. I was just citing that as an easy to check example. Tim

On Mon, Nov 15, 2021, 12:44 PM Josh-65 @.***> wrote:

It's the same behavior for any folder being opened externally. I don't think it make sense to change it just for the download since that makes a consistent issue. you can simply just close the other tab and/or don't open it in the first place. I'm sure there's also complications adding this in code since files wont know why the other tabs are open from the user.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/files-community/Files/issues/6925#issuecomment-969154775, or unsubscribe https://github.com/notifications/unsubscribe-auth/APWDHDEYZPTP2BQ6XN6YBH3UMFBGVANCNFSM5IB2DEHQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

boysent avatar Nov 15 '21 19:11 boysent

I like the idea, since tabs in Files should in general behave different from browser tabs. Browser tabs are about web sessions, hence multiple tabs can be different in content even though the same URL is opened. In Files on the other hand, there is no reason to open a new tab with the same path as an existing tab. :)

MalteTasler avatar Jan 02 '22 00:01 MalteTasler

There are extensions for web browser that also try to address this as a "site/URL already open, switch to that tab instead of opening a new tab" style. Just saying that the problem itself is somewhat universal.

clackwell avatar Feb 20 '24 22:02 clackwell

I like the idea, since tabs in Files should in general behave different from browser tabs. Browser tabs are about web sessions, hence multiple tabs can be different in content even though the same URL is opened. In Files on the other hand, there is no reason to open a new tab with the same path as an existing tab. :)

If you call it "state" instead of "content", the perspective may change:

State may include an open rename dialog/UI, selection/checkboxes, sorting, grouping, etc. It may be considered advanced to have two tabs of, say, the Download folder with different selections, sorting, group, etc. but...I am a friend of keeping things open, rather than limiting them (to exactly the use cases that I intend to cover). But I know that limiting things like this, and later opening the scope can also have its merits, and may prevent having to backtrack on some behavior or possibilities that may no longer work due to other changes. Both approaches may cause pain for some users. :)

clackwell avatar Feb 21 '24 10:02 clackwell

Also, as far as I know, the extensions for web browsers offer configurability and perhaps custom rules for the decision when to reuse a tab, and when not to. (On the other hand this likely does not make them easy to use for such more advanced cases.)

clackwell avatar Feb 21 '24 10:02 clackwell

This behavior will be included in the next release.

yaira2 avatar Aug 18 '24 20:08 yaira2