Files icon indicating copy to clipboard operation
Files copied to clipboard

Bug: Mixed/wrong language translations in context menu

Open SirePi opened this issue 1 year ago • 3 comments

Description

Opening the context menu on a system with multiple languages installed causes some of the commands to appear in a different language. See attached image for example

Image

My case could be even more specific as I am currently an English system and UI language, Italian locale for dates and numbers, and English and Traditional Chinese keyboards layouts installed. The "Notepad", "File Locksmith" and "PowerRenamer" entries are localized in Traditional Chinese instead of the expected English. Default context menu to show that they are actually properly shown in Windows

Image

Steps To Reproduce

  1. Have a system with multiple languages installed and possibly PowerToys or Notepad++ installed
  2. Open the context menu for any file

Requirements

Show the correct language for all menu entries

Files Version

3.7.11.0

Windows Version

10.0.19045.4894

User ID

524eb47d-c4cf-4bc8-962b-178c05e044d3

Log File

debug.log

SirePi avatar Oct 18 '24 10:10 SirePi

Well, I can work on this issue maybe

Sanidhyafeaturist avatar Oct 19 '24 09:10 Sanidhyafeaturist

I think this is an issue with Windows.

Lamparter avatar Oct 19 '24 12:10 Lamparter

@Lamparter I think that there should be modification on code like system is using multiple languages, the app should fetch the display language from the user's settings and apply it consistently

Sanidhyafeaturist avatar Oct 19 '24 15:10 Sanidhyafeaturist

The extension label is pulled from Windows but in theory, it should match File Explorer. It's worth looking into this to see if we can pull a different value.

yaira2 avatar Oct 27 '24 01:10 yaira2

https://github.com/notepad-plus-plus/nppShell/blob/7b715ada2749321f0bf8fc08a5587ea2d10ab9cf/NppShell.rc#L108

I wonder what the result of GetThreadUILanguage. Looks like SetThreadUILanguage changes .rc file's resource system switch.

0x5bfa avatar Oct 27 '24 03:10 0x5bfa

@SirePi Is this still an issue on v4.0.11 https://files.community/download

Josh65-2201 avatar Sep 18 '25 19:09 Josh65-2201

Btw, just casually: how can this bug's presence be tested in a practical way?

Is the specific locale / language pack necessary? If someone's got a link to step-by-step, testing, please - just refer me to the test docs :)

jpaulin avatar Sep 18 '25 19:09 jpaulin

Steps to reproduce are on the issues description

Josh65-2201 avatar Sep 18 '25 22:09 Josh65-2201

@SirePi Can you answer the above question

Josh65-2201 avatar Sep 24 '25 13:09 Josh65-2201