Files icon indicating copy to clipboard operation
Files copied to clipboard

Bug: Relevant actions are missing when right clicking recent files

Open yaira2 opened this issue 1 year ago • 7 comments

Description

The option to run exe files is missing when right clicking items in the Recent Files widget.

Steps To Reproduce

  1. Right click exe file from the Recent Files widget
  2. Notice that the "Run as admin" option isn't displayed

Requirements

  • display the "Run as admin" option when right clicking eligible files in the Recent Files widget
  • display the "Run as another user" option when right clicking eligible files in the Recent Files widget
  • display "Set as background" menu when right clicking eligible files in the Recent Files widget

Those are just a few examples, there are other actions as well.

Files Version

v3.4.1

Windows Version

Windows 11

Log File

NA

yaira2 avatar May 16 '24 20:05 yaira2

@yaira2 Could I work on this?

16dango avatar May 19 '24 23:05 16dango

Yes

Josh65-2201 avatar May 19 '24 23:05 Josh65-2201

Add them into RecentFilesWidgetViewModel and create commands only for home page.

https://github.com/files-community/Files/blob/895331a71673eb2195ae331c70f811be1de09df4/src/Files.App/Data/Factories/ContentPageContextFlyoutFactory.cs#L430-L431

https://github.com/files-community/Files/blob/895331a71673eb2195ae331c70f811be1de09df4/src/Files.App/Data/Factories/ContentPageContextFlyoutFactory.cs#L405-L417

This is not https://github.com/files-community/Files/labels/help%20wanted.

Ultimately, we should use unified context menu builder instead of spreading around widget view models.

0x5bfa avatar May 30 '24 02:05 0x5bfa

@0x5bfa we've been working towards a single context menu builder.

yaira2 avatar May 30 '24 13:05 yaira2

@0x5bfa how about the "Set as" options? Do we have a way to check if the right clicked item is an image?

yaira2 avatar May 30 '24 15:05 yaira2

@0x5bfa how about the "Set as" options? Do we have a way to check if the right clicked item is an image?

I think theres extension check.

0x5bfa avatar May 30 '24 15:05 0x5bfa

The recent files widget doesn't expose a property with the file extension

yaira2 avatar Aug 18 '24 21:08 yaira2