Bug: Focus is lost when changing tabs

[MarathonMax]

Description

I use the keyboard all the time. I like to use the down arrow to, well, move down a file/folder list. I also use the ctrl-tab/shift-ctrl-tab to move between opened tabs. When doing so and when getting back to a tab where I was down a list, the "cursor" position is not maintained; further more, I cannot use the down arrow to move down unless I use the mouse to click where I want to be.

Steps To Reproduce

1. Open two tabs
2. Move cursor to the center of the app window
3. Used ctrl + tab to switch to the second tab & ctrl + shift + tab to move back to the first tab
4. The cursor position moved

Requirements

Keep cursor in the same position

Files Version

3.1

Windows Version

W11 23H2

Log File

debug.log

[yaira2]

I'm having trouble reproducing this issue, this is what I tried

1. Opened two tabs
2. Moved cursor to the center of the app window
3. Used ctrl + tab to switch to the second tab & ctrl + shift + tab to move back to the first tab
4. The cursor position is still in the center

[Josh65-2201]

It might be from them being on 3.1. Can you also see if this is an issue in the preview version. https://files.community/download

[MarathonMax]

see video

https://photos.app.goo.gl/r6MC5H9APEDJKzG16

Maxime

On Thu, May 2, 2024 at 12:16 PM Josh65-2201 @.***> wrote:

It might be from them being on 3.1. Can you also see if this is an issue in the preview version. https://files.community/download

— Reply to this email directly, view it on GitHub https://github.com/files-community/Files/issues/15288#issuecomment-2090943229, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYGAVUJX3LLVAYPGXWFLUTZAJRGLAVCNFSM6AAAAABHDZHNW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJQHE2DGMRSHE . You are receiving this because you authored the thread.Message ID: @.***>

[yaira2]

I'm having a hard time following that, can you confirm if the repro steps I followed are correct?

[MarathonMax]

The issue is the same with the preview version

here's a take 2 video

https://photos.app.goo.gl/mrG9sY6WmE31rokr8

Maxime

On Fri, May 3, 2024 at 10:17 AM Yair @.***> wrote:

I'm having a hard time following that, can you confirm if the repro steps I followed are correct?

— Reply to this email directly, view it on GitHub https://github.com/files-community/Files/issues/15288#issuecomment-2093115835, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYGAVTU7SCJOZZJ26MGL53ZAOL7NAVCNFSM6AAAAABHDZHNW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJTGEYTKOBTGU . You are receiving this because you authored the thread.Message ID: @.***>

[yaira2]

@MarathonMax I watched the video, but it seems like the cursor position stays the same when your switching tabs.

It's possible I misunderstood what the issue is, so further clarification would be appreciated. It looks like we're both following the same steps, but it'll help if you can confirm either way.

1. Opened two tabs
2. Moved cursor to the center of the app window
3. Used ctrl + tab to switch to the second tab & ctrl + shift + tab to move back to the first tab
4. The cursor position is still in the center

[MarathonMax]

Yes "grey area" stays the same but I can no longer use keyboard to go up or down

Le sam. 4 mai 2024, 22 h 47, Yair @.***> a écrit :

@MarathonMax https://github.com/MarathonMax I watched the video, but it seems like the cursor position stays the same when your switching tabs.

It's possible I misunderstood what the issue is, so further clarification would be appreciated. It looks like we're both following the same steps, but it'll help if you can confirm either way.

1. Opened two tabs
2. Moved cursor to the center of the app window
3. Used ctrl + tab to switch to the second tab & ctrl + shift + tab to move back to the first tab
4. The cursor position is still in the center

— Reply to this email directly, view it on GitHub https://github.com/files-community/Files/issues/15288#issuecomment-2094560077, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYGAVUUXECXQCJTBKAMWMLZAWMUHAVCNFSM6AAAAABHDZHNW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJUGU3DAMBXG4 . You are receiving this because you were mentioned.Message ID: @.***>

[yaira2]

@Josh65-2201 are you able to repro this issue?

[Josh65-2201]

Yes, It's not the actual cursor moving but the tab selection moves to the tabs bar rather than the select file in that tab and stops triggering file navigation when using the arrow keys.

[yaira2]

I see, I can't reproduce the focus issue either but at least that points us in the right direction.

[MarathonMax]

Yes. You should have received the video.

Le lun. 6 mai 2024, 10 h 48, Yair @.***> a écrit :

@Josh65-2201 https://github.com/Josh65-2201 are you able to repro this issue?

— Reply to this email directly, view it on GitHub https://github.com/files-community/Files/issues/15288#issuecomment-2096214970, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYGAVREX6MTY3A64Z726SDZA6J3XAVCNFSM6AAAAABHDZHNW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJWGIYTIOJXGA . You are receiving this because you were mentioned.Message ID: @.***>

[MarathonMax]

I am glad that you could reproduce the issue

Le lun. 6 mai 2024, 11 h 01, Josh65-2201 @.***> a écrit :

Yes, The tab selection moves to the tabs bar rather than the select file in that tab and stops triggering file navigation when using the arrow keys.

— Reply to this email directly, view it on GitHub https://github.com/files-community/Files/issues/15288#issuecomment-2096245899, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYGAVQ55L5ZUVA33QZREGTZA6LOHAVCNFSM6AAAAABHDZHNW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJWGI2DKOBZHE . You are receiving this because you were mentioned.Message ID: @.***>

[yaira2]

A fix will be included with v3.5.