files-community
Code Quality: Convert into `await using` statement or declaration
Description
using (var stream = File.OpenRead(_item.ItemPath))
to
await using (var stream = File.OpenRead(_item.ItemPath))
In .NET, classes that own unmanaged resources usually implement the IDisposable interface to provide a mechanism for releasing unmanaged resources synchronously. However, in some cases they need to provide an asynchronous mechanism for releasing unmanaged resources in addition to (or instead of) the synchronous one. Providing such a mechanism enables the consumer to perform resource-intensive dispose operations without blocking the main thread of a GUI application for a long time.
The IAsyncDisposable.DisposeAsync method of this interface returns a ValueTask that represents the asynchronous dispose operation. Classes that own unmanaged resources implement this method, and the consumer of these classes calls this method on an object when it is no longer needed.
Source: https://stackoverflow.com/questions/58610350/what-is-the-difference-between-using-and-await-using-and-how-can-i-decide-which
Concerned code
Generated using Jetbrains Rider:
Gains
- UI will not freeze while disposing a resource
Requirements
- Convert all asynchronous using to
async using
Comments
It's possible to make a single PR using this button :)
Out of curious, what IDE are you using? I also wanna generate this list lol.
Out of curious, what IDE are you using? I also wanna generate this list lol.
Rider, but you can install ReSharper at VS to obtain the same result. You can get a free license if you are a FOSS contribuitor.
Oh they are kind. Why do you think those warnings won't be shown in VS2022 by default and what should we do to should those issues that would improve performance.
Oh they are kind. Why do you think those warnings won't be shown in VS2022 by default and what should we do to should those issues that would improve performance.
I guess this is why JetBrains makes money lol, if VS showed these problems ReSharper wouldn't exist. Maybe because of some limitation?
Yair said about benchmarking, I think this is valid. There is also dozens of issues types when I run the analyzer, but I opened just the most importants, some of them I think they don't make sense, like var instead of the explicit type, not worth a PR.
I'm not sure if Files counts as a project, since users have to pay for the version in the Microsoft Store
From here https://www.jetbrains.com/community/opensource/#support
That's absolutely right lol I was wondering why VS doesn't show warnings that comes from the official analyzers(IDE????, C????) while Rider shows. But I seemed to have misunderstood. Thanks.
Really nice features.
I'm not sure if Files counts as a project, since users have to pay for the version in the Microsoft Store
From here https://www.jetbrains.com/community/opensource/#support
I saw some projects with "Thanks for JetBrains" at the end of the README file, maybe if you contact JetBrains sales they can make a exception for Files as this is a big project .
I'm not sure if Files counts as a project, since users have to pay for the version in the Microsoft Store
I wouldn't consider the store version as commercial, the sideload version has all the same features and users get the same level of support. In fact, the sideload version has many times the number of users as the store version.
Sorry for the unrelated comments, Yair. I don't mind you deleting them.
Besides that, I'm onboard where applicable. Basically classes that implement IAsyncDisposable need to release unmanaged objects asynchronously but using Disposable may cause hangs.