Files icon indicating copy to clipboard operation
Files copied to clipboard

Fix: Fixed issue where drive folders in sidebar have wrong properies category

Open ZTL-UwU opened this issue 2 years ago • 3 comments

Resolved / Related Issues

  • [x] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers. Closes #14530

Validation How did you test these changes?

  • [x] Did you build the app and test your changes?
  • [ ] Did you check for accessibility? You can use Accessibility Insights for this.
  • [ ] Did you remove any strings from the en-us resource file?
    • [ ] Did you search the solution to see if the string is still being used?
  • [ ] Did you implement any design changes to an existing feature?
    • [ ] Was this change approved?
  • [x] Are there any other steps that were used to validate these changes?
    1. pin a drive to the side bar
    2. right click to open the properties window

Screenshots (optional) image

ZTL-UwU avatar Jan 24 '24 01:01 ZTL-UwU

This does NOT fix #14522, this only fixes the category issue in the Pinned items which is #14530. The Cloud Drive Section should be a separate fix.

ZTL-UwU avatar Jan 24 '24 05:01 ZTL-UwU

@ZTL-UwU can you clarify what issue this is trying to solve?

yaira2 avatar Jan 28 '24 16:01 yaira2

All the pinned items were stored as locationItems, which makes the categories of all the property window folders. See the screenshots in #14530.

This PR allows the pinned items to be driveItems as well, which fixes the property window for both pinned drives and pinned cloud drives.

@yaira2

ZTL-UwU avatar Jan 29 '24 00:01 ZTL-UwU

Thank you for your contribution. This idea has not been planned and not been expected. Closing for now and can you describe how to fix this in the issue? And I think this issue can be fixed with the cloud one.

0x5bfa avatar Feb 22 '24 08:02 0x5bfa