filebrowser icon indicating copy to clipboard operation
filebrowser copied to clipboard
verified publisher icon filebrowser

Invitation code

Open niubility000 opened this issue 4 years ago • 6 comments

fixed: #1710 01 02 03 04 05

And when "allow users to signup" is selected, but "use invitation code" is not selected, the invitation code input box will be hidden in the signup page. 06

niubility000 avatar Dec 28 '21 03:12 niubility000

I think it should be possible to create multiple unique invitation codes

o1egl avatar Jan 11 '22 20:01 o1egl

I think it should be possible to create multiple unique invitation codes

Done! Just use ; to separate multiple unique invitation codes, and use if !strings.Contains(";"+d.InvitationCode+";", ";"+info.InvitationCode+";"){ to compare them.

niubility000 avatar Jan 12 '22 08:01 niubility000

I think it should be possible to create multiple unique invitation codes

Done! Just use ; to separate multiple unique invitation codes, and use if !strings.Contains(";"+d.InvitationCode+";", ";"+info.InvitationCode+";"){ to compare them.

This is not exactly what I had in mind. I think it is better to have a list similar to the shares and have an object in the database that indicates if the code is active or not and which user was registered with it.

o1egl avatar Jan 12 '22 11:01 o1egl

If the code is active, other visitors can't use it any more to sign up? That's unique. It's a little bit more complicated.

niubility000 avatar Jan 12 '22 13:01 niubility000

Honestly having so many commits with the message "Add files via upload" makes it hard to review the code. Being a feature integrated into the authentication system, I think the code changes should be well structured, semantically grouped, and with good commit messages.

adrium avatar Jan 13 '22 10:01 adrium

Honestly having so many commits with the message "Add files via upload" makes it hard to review the code. Being a feature integrated into the authentication system, I think the code changes should be well structured, semantically grouped, and with good commit messages.

I can only visit github using browser through a web proxy. I need to upload and commit the files one by one. That's why there are so many commits and they are not grouped. You can just review the 'files changed' section.
Next time I will write commit messages. And I am not a professional programmer. So feel free to modify them or make a new PR.

niubility000 avatar Jan 13 '22 14:01 niubility000

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Sep 10 '22 02:09 github-actions[bot]

This PR was closed because it has been stalled for 5 days with no activity.

github-actions[bot] avatar Sep 15 '22 02:09 github-actions[bot]