filament icon indicating copy to clipboard operation
filament copied to clipboard

Laravel 11: Remove Doctrine DBAL

Open hafezdivandari opened this issue 2 years ago • 0 comments

Description

Doctrine DBAL has been removed from Laravel 11.x:

This PR removes doctrine/dbal from filament and uses following Laravel's native schema methods, that are stable since Laravel 10.38, instead:

  • Schema::getColumns($table)
  • Schema::getColumnListing($table)
  • Schema::getIndexes($table)

PS 1: It's my first time contributing to filament, please let me know if I've missed anything, and sorry about that! PS 2: This PR targets laravel-11 branch (#10972), please let me know if you prefer anything else. PS 3: I tried to keep the changes as minimum as possible, but this PR changes the methods' signatures on packages/support/src/Commands/Concerns/CanReadModelSchemas.php, IDK if you consider this as a breaking change or not.

Code style

  • [x] composer cs command has been run.

Testing

  • [ ] Changes have been tested.

Documentation

  • [x] Documentation is up-to-date.

hafezdivandari avatar Feb 15 '24 18:02 hafezdivandari