Colocalisation_Analysis icon indicating copy to clipboard operation
Colocalisation_Analysis copied to clipboard

Fix Colocalisation_Test window crash on multiple runs

Open pvlaraia opened this issue 4 years ago • 2 comments

Summary: If a script uses Colocalisation_Test, and closes the result window, subsequent attempts to run Colocalisation_Test will crash because the reference to the window will still be there, but the attempts to write to the window will crash because the window was closed. To verify, revert changes to Colocalisation_Test.java & run the new test case added - the 2nd attempt to run coloc in the unit test will fail.

The solution was to cleanup the window ref when a window is closed.

pvlaraia avatar Sep 04 '21 07:09 pvlaraia

@ctrueden I see you've been involved in a lot of the most recent commits, is this something you could consider merging in?

pvlaraia avatar Oct 06 '21 03:10 pvlaraia

@pvlaraia Thanks for the ping. I'll try to review and merge it this week.

ctrueden avatar Oct 06 '21 13:10 ctrueden