fig02
fig02
oot is ready to merge this fwiw, but dragorn marked it as a draft over there for some reason @Dragorn421 was this just to hold it until mm was ready?
yeah Id be very suprised if this was an actual version difference. Definitely wouldnt go around adding tcrf entries and stuff for something tested on emualtor
I agree with cadmic that I wouldnt mind having more friendly translations here for the sake of ease of use. But it would go against the intended usage of `T`...
Think I would prefer `PLAYER_STATE1_USING_SHIELD` to mirror `PLAYER_STATE1_USING_BOOMERANG` and `PLAYER_STATE2_USING_OCARINA` (https://github.com/zeldaret/oot/pull/2277) Also want to note I have already started documenting shield related Upper Actions and Main actions. We keep seeming...
Since the flag gets set in so many places I would personally prefer to get those functions documented first. But this name is probably accurate and could be named early,...
Well then "shielding" isnt really either haha. That state is kinda strange anyway, it doesnt even have a collider so it doesnt block anything. Its pretty useless. I think its...
The original animation names call it "defending", but I dont think any of these work for two handed which isnt blocking guarding or defending anything. Im fine with just going...
Thanks for being flexible and trying out a new approach, appreciate it. I like the way this looks alot more
Thanks. Would personally prefer to wait on the idle setup function. There are so many idle action setup wrappers, and I think we need to figure them out together. Plan...
I feel like there are docs to be done here, they just arent to everyone's taste in their current state. I think closing it will ultimately result in people forgetting...