Aaron Adams

Results 101 comments of Aaron Adams

I guess define not working? I have to manually attach to the node process with the latest changes in order for the tests to start running, but otherwise it works.

Not sure. When it worked for me it didn't work for you both :D I can do some more tests, since the devshell recently messed up so maybe has something...

It's a good question. I was also recently pondering if just adding some module options for tlp package would be better. I wasn't actually aware of tlp until this PR....

I'm finding this type of thing increasingly jarring now that I'm using cursorless in neovim because the cursorless commands (at least for now) don't work or manipulating text on the...

> I think it should be easy to implement as long as we have a way to open the default browser that works on linux/windows/osx. > > Maybe using something...

Does this mean I should hold off an updating old tests for now to see how this goes? Porting the lua, bash, and nix tests are still on my list...

It's not identical. My thinking is that you would call it with something like `vim.fn.getpos("'>")` and `vim.fn.getpos("'>")` as the visual selection start/end positions to get back most of the coordinates...

I didn't even try to use getregionpos() in the end, as it was already simple enough without: https://github.com/saidelike/cursorless/pull/9 Once that PR is merged can close this issue imo.

It's not required no. Since it's a development shell, and I assume people using it would be committing things, it made sense to install the hooks? I don't mind removing...

Ah interesting, that makes sense. Bad assumption on my part. I'll send a PR to remove it. Why don't you use pre-commit locally out of curiosity. I specifically wonder about...