node-bacstack
node-bacstack copied to clipboard
fh1ch
Support for BBMD messages and COV pushing
Checklist
- [X] I've read and followed the Contribution Guide.
- [X] My commit messages reference affected issues and mention breaking changes if applicable.
- [X] I've updated / wrote inline documentation for the source code affected by my changes.
- [ ] All mandatory CI checks have passed (see when Pull Request has been submitted).
What does this Pull Request do
This adds support for a couple of BACnet messages useful when implementing a client device. It allows the device to appear as a BBMD (sort of a BACnet proxy server), which is useful for some systems (such as Johnson Controls Metasys) which can only talk to BBMD proxies and cannot talk to remote BACnet devices directly.
It also adds the ability to send COV notifications. A remote BACnet system can already subscribe to a data element provided by a device based on this library, however without this addition there is no way to make use of this subscription to push updates to the remote system as they occur.
Many thanks for your review, and apologies for my own delayed reply, as I have been away for a few weeks.
I've pushed some changes and left comments explaining my reasoning for others, so I hope this helps.
Feel free to cherry-pick or edit as necessary. I tried to structure the PRs so that you can merge the other non-BBMD ones (e.g. #128 and #134) without too much hassle, so hopefully you won't need to cherry pick these ones. Both #128 and #134 are included here, as I based the BBMD patch on top of those two.
This is great! @adam-nielsen would you mind updating this on top of the latest master?
I believe it has already been merged into the fork at https://github.com/BiancoRoyal/node-bacstack along with a bunch of other fixes, as this one appears to be abandoned now. So I'd probably suggest trying that one first.