AirReceiver icon indicating copy to clipboard operation
AirReceiver copied to clipboard

Update RaopAudioHandler to support the min-latency SDP attribute in iOS 5.1.1

Open pentateu opened this issue 13 years ago • 2 comments

Hi,

First let me say thank you for the great work. I'm building a Android in-car system and I'll use AirPlay to support streaming of iOS audio, photos and video and your project gives me a huge head start.

Now to the issue. When I tested with iOS 5.1.1 the RaopAudioHandler was throwing an exception because one of the SDP attributes have a dash '-' and the regular expression does not support it.

The attribute is: 'min-latency'

I have changed the regular expression to be:

protected static Pattern s_pattern_sdp_a = Pattern.compile("^(\w+):?(.*)$");

That can be improved to be more restrictive, but that is working fine at the moment.

I have also changed it to protected to allow for the JUnit to have access to the field and run the unit tests.

Cheers, Rafael

pentateu avatar Jun 18 '12 22:06 pentateu

Will fix. Actually, this is the second or third time a new field added by an iOS upgrade his triggered this type of problem, so I think I'm just going to make all the regexes as lenient as possible. It seems that being strict here doesn't buy us anything.

fgp avatar Jun 22 '12 14:06 fgp

Ah, actually I think this is already fixed, but only in the STABLE_1_X branch. The master branch is currently unmaintained - I branched off STABLE_1_X because I intended to rewrite the audio handling quite a bit, but then ran out of time. Guess I shouldn't have used the master branch for this...

fgp avatar Jun 22 '12 14:06 fgp