largetext

largetext copied to clipboard

Evening. I used you library and it works great. I found it lacking 2 features and I decided to contribute them back. Also I found 2 issues that I wrote...

akhomchenko

Thank you a lot for library! I find it useful and interesting to study. I want to contribute some features but local build fails for me so I've decided to...

akhomchenko

@fge I started understanding this project and as soon as I executed `LargeTextFactoryTest`, it's broken. There are mainly two test cases which are broken: 1. `cannotSetNullCharset` 2. `windowSizeUnitMustNotBeNull`

ghost

This caused a little bit of head scratching when my regex group was returning 'INSTANCE' :)

seeflat

ThreadSafeLargeText is not thread safe

1

The `ThreadSafeLargeText`s use of a **static** `ThreadLocal` makes it _not thread safe_. ```kotlin //written in kotlin, corresponding java can be provided if need be. @Test fun `when loading text on...

Groostav

``` Exception in thread "main" com.github.fge.largetext.LargeTextException: decoding error at com.github.fge.largetext.load.DecodingStatus.getTotalSize(DecodingStatus.java:211) at com.github.fge.largetext.load.TextDecoder.getTotalChars(TextDecoder.java:172) at com.github.fge.largetext.LargeText.length(LargeText.java:129) at java.util.regex.Matcher.getTextLength(Matcher.java:1283) at java.util.regex.Matcher.reset(Matcher.java:309) at java.util.regex.Matcher.(Matcher.java:229) at java.util.regex.Pattern.matcher(Pattern.java:1093) at com.stellaris.Stellaris.getGameVersion(Stellaris.java:93) at com.stellaris.Stellaris.main(Stellaris.java:226) Caused by: java.io.IOException: unable...

KaiserKatze

Code: ``` java public final class TraceReadTest { private static final Path ZIP_PATH = Paths.get("/home/fge/t.zip"); private static final Map ZIPFS_ENV = Collections.singletonMap("readonly", "true"); private static final String TRACE_PATH = "/trace.csv";...

fge

Optional config setting for protection against accidental use of `toString()` during development

4

Please consider adding some sort of optional configuration setting, to protect against accidental use of `toString()`, which in the case of largetext is...LARGE TEXT. Although it is unlikely that this...

aliteralmind