Frederic Freyer

Results 408 comments of Frederic Freyer

I tried rewriting the docstrings for `should_dim_convert()` and `@convert_targets` to make them clearer but I'm not sure if I actually correctly understood them. So please take another look at them....

I've been thinking about whether `Transformation`s should be part of what `space` controls or not, and I'm leaning towards separating them. Conceptually I see `Transformation`, i.e. the transform_func, translate!, rotate!...

With higher test accuracy this fails https://github.com/MakieOrg/Makie.jl/blob/83fc003e775c9468aa362a15b45b9e8d675234c6/ReferenceTests/src/tests/examples3d.jl#L461-L472 because the axis limits have become a bit larger, changing the generated grid. I assume this happens because the data_limits of the contour...

> We kind of deprecated rotation for meshscatter in 0.20! We did? Neither NEWS nor the blog post mentions this. There should be an error/deprecation message for this, yea. Also...

`space 3D` failing is expected because the near and far planes are now tight to the `finallimits` in Axis3. This should also change OIT there, but I don't think we...

Could we add something like `plot!(..., passthrough = (; internal_attrib = ...))` to skip this check? I think otherwise this breaks some of the hackier stuff where you overwrite defaults...

> @ffreyer I'd go case by case through the errors this throws, I'm not sure in what cases what you wrote is applicable. Maybe some can be refactored? Some will...

> > you could add mass and gravity to a scatter plot if you do some kind of physics simulation > > I think those usecases, while interesting, distract from...

For something like ```julia on(my_obs) do ... val = to_value(get(plot.attributes, :special_key, default)) ... end ``` that's fine but for ```julia onany(my_obs, get(plot.attributes, :special_key, default_obs)) do ... ... end ``` it's...