docs icon indicating copy to clipboard operation
docs copied to clipboard

fix(docs): fix bug in tooltip hover

Open joshua-demo opened this issue 1 year ago • 3 comments

Proposed Changes

[Able to hover over tool tip message and click on Agentverse link]

Types of changes

What type of change does this pull request make (put an x in the boxes that apply)?

  • [ ] Content update.
  • [x] Bug fix (non-breaking change that fixes an issue).
  • [ ] New feature added (non-breaking change that adds functionality).
  • [ ] Breaking change (fix or feature that would cause existing functionality to stop working as expected).
  • [ ] Something else (e.g., tests, scripts, example, deployment, infrastructure).

Checklist

Put an x in the boxes that apply:

  • [x] I have read the CONTRIBUTING guide
  • [x] Checks and tests pass locally

joshua-demo avatar Sep 11 '24 05:09 joshua-demo

hey @joshua-demo nice catch, you're right the hover effect isn't very good. I think for best UX we should have it click on, click anywhere off. Would you like to update for this functionality, else we'll fix this 👍

devjsc avatar Sep 11 '24 13:09 devjsc

hi @devjsc I found it more common when there is an information svg, for it to be a tooltip where it will automatically hide the modal after a small amount of time when hovering off the tootip modal or the information svg. If you still think the button version is better, I can also update for that functionality.

joshua-demo avatar Sep 11 '24 17:09 joshua-demo

Interesting, i thought best UX for modals is click anywhere for off, expected behaviour (imo):

  • click on tooltip icon, popup displays
  • scroll, click on tooltip icon, or click anywhere else on screen popup closes.

What do you think @gautamgambhir97 ?

devjsc avatar Sep 12 '24 08:09 devjsc

@gautamgambhir97 can you update this PR

  • click on tooltip icon, popup displays
  • scroll, click on tooltip icon, or click anywhere else on screen popup closes.

devjsc avatar Nov 22 '24 13:11 devjsc

@gautamgambhir97 can you update this PR

  • click on tooltip icon, popup displays
  • scroll, click on tooltip icon, or click anywhere else on screen popup closes.

Yeah, I'll update it

gautamgambhir97 avatar Nov 25 '24 07:11 gautamgambhir97