LogosLinuxInstaller icon indicating copy to clipboard operation
LogosLinuxInstaller copied to clipboard

[TESTING] Adds optargs ability to disable zenity and to silence the script

Open thw26 opened this issue 3 years ago • 2 comments

This PR seeks to make the scripts usable without Zenity, i.e., solely via the CLI. It does this on an opt-out basis; the default install will remain Zenity, but for keyboard warriors they now can avoid it, or they can schedule automated installs/updates, for whatever purpose. I'm not here to say no, just making it possible.

This brings a number of updates to the table. I found the removeLibraryCatalog option was missing on the *10 Logos.sh scripts, so that was readded.

The main additions are:

  • Adding optargs to the script; this should be distro agnostic.
  • Adding a function [use_zenity()] which enables the disabling of Zenity calls in the script. Where necessary, if/else logic has been added.
  • Adding a function [verbose()] which enables the silencing of output by the script. This makes possible a silent install.
  • Fully implementing the help() function introduced in #66 and #79.

This does not add optargs to the Logos.sh or the controlPanel.sh scripts; it only modifies the installer (*_Setup.sh) scripts.

More options can be added down the road. This should be enough to get started.

thw26 avatar Oct 22 '22 02:10 thw26

Last push added Verbum10 removeLibraryCatalog option.

thw26 avatar Oct 22 '22 02:10 thw26

These script changes now need tested. These bring in the same changes as #32 for Logos 9 and 10. I may have missed an echo or a zenity popup or requirement. Some immediate things that I can think of that need to be tested with these changes.

  • [ ] Does verbose() function silence CLI output?
  • [ ] Does use_zenity() stop all Zenity popups when -Z is passed?
  • [ ] Does the script successfully install when not using either option?
  • [ ] Does the script successfully install with only -q passed?
  • [ ] Does the script successfully install with only -Z passed?
  • [ ] Does the script successfully install with -qZ passed?

thw26 avatar Oct 22 '22 02:10 thw26

This PR needs major updates. Closing as stale.

thw26 avatar Jan 20 '23 15:01 thw26