embedded-postgres icon indicating copy to clipboard operation
embedded-postgres copied to clipboard
verified publisher icon fergusstrange

Replace xz library with newer one

Open der-eismann opened this issue 1 year ago • 4 comments

Reasoning:

  • Last commit in this repo was 7 years ago, project is dead
  • It's not versioned and doesn't have a go.mod
  • License can't be detected by pkg.go.dev & other tools
  • Causes pkg.go.dev to not show any documentation
  • Tools that check for license compliance might fail on embedded-postgres because it pulls in github.com/xi2/xz

der-eismann avatar Mar 21 '24 15:03 der-eismann

Awesome @der-eismann, would be be a great upgrade.

fergusstrange avatar Mar 21 '24 21:03 fergusstrange

can we move forward with this change? I want to include this in one of my projects, but the license check tooling is failing on this exact thing

Araoz-Lucas-bah avatar Apr 29 '24 21:04 Araoz-Lucas-bah

Unfortunately I have no idea why the tests on Windows and macOS are failing, I can't reproduce it here.

der-eismann avatar Apr 30 '24 12:04 der-eismann

Hmmm this is interesting @der-eismann. I can confirm your changes pass locally with an M2 Macbook. Perhaps try boosting the windows/mac build runners to see if you have any luck here?

fergusstrange avatar May 10 '24 06:05 fergusstrange