gtoolkit icon indicating copy to clipboard operation
gtoolkit copied to clipboard

Lepiter: Roam Import breaks when collapsible parenthesis are used inside the DB

Open Stvad opened this issue 4 years ago • 11 comments

The functionality I refer to: https://twitter.com/RoamResearch/status/1338741084256669699?s=20

When you put something between double parenthesis (and it's not a block reference) - Roam will show that as a collapsed roam glyph.

When this is used in DB you're trying to import - the import breaks with the assertion on the length of the uuid (as it's trying to treat that thing as a block).

image

Stvad avatar Nov 30 '21 21:11 Stvad

for the record - tried again and this is still broken :(

Stvad avatar Jun 20 '22 01:06 Stvad

image on removing the cases when the above breaks, it crashes now with json parser being unhappy about unicode encoding 🙈

Stvad avatar Jun 20 '22 01:06 Stvad

and then image

Stvad avatar Jun 20 '22 01:06 Stvad

Thanks for trying.

We expect to get a UTF-8 encoding.

It's hard to fix problems without a concrete input that we can reproduce. Do you happen to have such an input that we can utilize?

girba avatar Jun 20 '22 05:06 girba

will provide a simplified test input in a bit!

Stvad avatar Jun 21 '22 22:06 Stvad

ok, first one is easy - havin a string longer then 24 chars in brackets triggers the assert lepiter-canary.zip

Stvad avatar Jun 22 '22 00:06 Stvad

We expect to get a UTF-8 encoding.

I think that one is caused by Roam mangling an emoji sometimes when it's at the end of the block 🤔. It makes sense that you can't parse that mangling, but it should probably just result in a weird character vs import getting broken

Stvad avatar Jun 22 '22 00:06 Stvad

for the last error - I thought it'd be something like a reference to a block that doesn't exist anymore, but failing to create a repro for that so far

Stvad avatar Jun 22 '22 00:06 Stvad

We can address this if we get a sample that reproduces the error. Until then, I am closing the issue.

girba avatar Jul 17 '23 17:07 girba

ok, first one is easy - havin a string longer then 24 chars in brackets triggers the assert lepiter-canary.zip

uh, I've attached this a while back as a repro of the original problem describe in the issue..

Stvad avatar Jul 17 '23 17:07 Stvad

Ah, I missed that.

girba avatar Jul 18 '23 07:07 girba