feeless
Wallet file encryption
It would be good to optionally have the wallet encrypted. For now I think the whole wallet file should be encrypted, rather than individual wallets. A new issue should be made for individual wallets.
This should use a well established cryptography algorithm.
An example to encrypt the whole wallet file:
export FEELESS_WALLET_FILE=gak.wallet
feeless wallet password
Enter a new password:
Confirm password:
Password added.
Doing it again will ask for the existing password:
feeless wallet password
Enter existing password:
Enter a new password:
Confirm password:
Password replaced.
When accessing keys, a password will be requested:
feeless wallet address
Enter password:
nano_1abcd...
Having an environment variable would be handy although insecure:
FEELESS_WALLET_PASSWORD=hunter2 feeless wallet address
nano_1abcd...
You can remove a password and make it unencrypted again:
feeless wallet password --remove
Enter existing password:
Password removed.
For encryption maybe we could use one of these? https://github.com/RustCrypto/stream-ciphers
Yes, I think so. Not sure what's good though. Maybe see what other crypto wallets (Nano, Ethereum, Bitcoin) are using?
Bitcoin seems to use AES/SHA512
https://github.com/bitcoin/bitcoin/blob/c7ad94428ab6f54661d7a5441e1fdd0ebf034903/src/wallet/crypter.cpp#L46