Federico Ciardi comments

Results 198 comments of


                                            Federico Ciardi

don't let arbitrary characters through as integers

Sure, but `toInt` validation logic should limit to a call to `isInt`. I think that we should update `isInt` signature

don't let arbitrary characters through as integers

Let's wait @profnandaa and @tux-tn

discussion: support for TypeScript

On [`express-validator`](https://github.com/express-validator/express-validator) we have some incomplete type definitions that may work well as a starting point.

SyntaxError: Cannot use import statement outside a module

@0kyn in that way he would use commonjs modules and I am not sure if it's what he's trying to achieve. @zeel-codder to use `import ... from ...` you have...

added a github action

Oh, I didn't meant that, I just wanted to remark that if I don't review after something I suggested is fixed it isn't a problem since there are still project...

Improve docs

For example `eslint` uses a similar approach. ([for all rules](https://github.com/eslint/eslint/blob/cd2e584aa5a87c425177fb84a9cd6b05624fec43/lib/rules/array-bracket-spacing.js#L13-L53))

Improve docs

Pinging this, I have just analyzed an algolia report of express-validator website where most of the searches with no result are related with the docs of this repo.

Improve docs

I am not aware of any standard, it would be cool to create one🔥

Improve docs

Yes, JSdoc could be used but if I am not wrong is really limited. However with it we could for sure automate doc generation with a pre-commit hook

Improve docs

Docusaurus can't handle that schema design, but since it is json it would be really easy to generate docs. I've been working with tsdoc parser in the last couple weeks...