feast-dev
ci: Add missing CI for feast-operator image builds
What this PR does / why we need it:
Missing CI related to https://github.com/feast-dev/feast/pull/4145
This change will require that the following image repos are created (if they don't already exist) -
gcr.io/kf-feast/feast-operator
gcr.io/kf-feast/feature-server
Which issue(s) this PR fixes:
https://github.com/feast-dev/feast/issues/4144
@woop is this something you can help with? the creation of those repos that is. or, maybe increased perms for @franciscojavierarceo or @jeremyary so they can handle it?
Just to confirm, is there a reason we'd use kf-feast on GCR instead of dockerhub? Also, @franciscojavierarceo can you confirm what access you have already?
@woop its used in .github/workflows/master_only.yml, which is named "integration-tests-and-build". it appears to run upon PR merge into the master branch and is a way a ensure image builds/pushes are working prior to release.
Hey @franciscojavierarceo you should have GCR access now if you check your GCP console.
@franciscojavierarceo @woop were these repos ever added? should we revisit this? it may help us troubleshoot some of the release build issues we've been facing. don't forget to add write perms for the gh actions robot account.
Sorry been out of the loop on this one @tchughesiv does this still need review or action from me?
@franciscojavierarceo fixed... but as a reminder, this PR shouldn't be merged until the repos in the description are created and provided push access to the workflow robot account.
@tchughesiv so the robot should have access. The gcr.io/kf-feast artifact registry already exits so I believe once we try to push the images it should create the artifact/image.
@franciscojavierarceo i guess it's worth a shot, but my expectation is that those new repos will have to exist first. especially because this registry has been deprecated and there's a migration guide. https://cloud.google.com/artifact-registry/docs/transition/auto-migrate-gcr-ar