feast icon indicating copy to clipboard operation
feast copied to clipboard

two featureviews share the same name between stream feature views and regular feature views

Open sutodi opened this issue 2 years ago • 4 comments

I have a stream feature view running fine in 0.29. When upgrading to 0.34, getting error on doing feast apply “feast.errors.ConflictingFeatureViewNames: The feature view name: job_stream refers to feature views of different types.” Printing type in registry.py in function _check_conflicting_feature_view_names where error is coming. “print(“feature view instance”, feature_view.proto_class, type(name_to_fv_protos.get(feature_view.name)))” getting output: feature view instance <class ‘feast.core.FeatureView_pb2.FeatureView’> <class ‘feast.core.StreamFeatureView_pb2.StreamFeatureView’> I feel like this might be because of https://github.com/feast-dev/feast/pull/3582

sutodi avatar Nov 14 '23 09:11 sutodi

@loftiskg @achals @adchia

sutodi avatar Nov 16 '23 04:11 sutodi

@shuchu just confirming if this issue still required any attention or can be closed based on you PR which merged already

redhatHameed avatar Feb 20 '24 17:02 redhatHameed

It was fixed and we are good to close it.:)

shuchu avatar Feb 20 '24 17:02 shuchu

Thanks @shuchu for confirming.

@jeremyary @etirelli can you help to close this.

redhatHameed avatar Feb 20 '24 17:02 redhatHameed