feast icon indicating copy to clipboard operation
feast copied to clipboard

Support 64-bit hash

Open felixwang9817 opened this issue 3 years ago • 2 comments

The Redis online store implementation currently uses the murmur3 32-bit hash. As noted in this discussion, there is a reasonably high chance of collisions when using 32-bit hashes (this has nothing to do with the murmur3 implementation). Feast should support 64-bit hashes.

felixwang9817 avatar Aug 25 '22 18:08 felixwang9817

This would probably require a bump in the entity_key_serialization_version since the hash change would be non-backwards-compatible.

achals avatar Aug 25 '22 19:08 achals

I think the fix may not need to be backwards-compatible. the keys in redis will be different anyway (the old entity in cache will expire naturally), the fix just needs both offline-writing&online-fetching being consistent.

flyingclouds1985 avatar Aug 25 '22 23:08 flyingclouds1985

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 26 '22 11:12 stale[bot]