feast icon indicating copy to clipboard operation
feast copied to clipboard

Incorrect event timestamps being returned with get_online_features

Open adchia opened this issue 4 years ago • 3 comments

Expected Behavior

Event timestamp in the OnlineResponse is the real event timestamp.

Current Behavior

In https://github.com/feast-dev/feast/blob/master/sdk/python/feast/feature_store.py#L1730, we return the current time for all online features. In reality, we want to read from the online store to find the event timestamps and then populate them here

Possible Solution

https://github.com/feast-dev/feast/pull/2174/files is a start (slightly outdated though).

adchia avatar Jan 31 '22 17:01 adchia

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 12 '22 11:06 stale[bot]

@adchia was this actually fixed?

woop avatar Jun 13 '22 14:06 woop

nope. hence why I edited the code pointer just now. It still outputs the now() timestamp

adchia avatar Jun 13 '22 14:06 adchia

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 20 '22 23:12 stale[bot]