Entities are never deleted from the Registry

[achals]

Expected Behavior

When an entity is removed from the feature repo, it should be removed from the feature registry.

Current Behavior

Entities are only added, never removed from the Registry. This is a storage leak of sorts.

Steps to reproduce

• feast init
• In the new feature repo, feast apply
• Add a new entity in the feature repo. feast apply.
• Remove the new entity from the feature repo. feast apply.
• feast registry-dump will have deleted entity, even though no feature tables or views depend on it.

Possible Solution

in repo_operations.py#apply_total, we need to keep track of the entities to delete, add an API in the feature store to delete entites, and call this new API.

[amommendes]

Hey @achals, is this still open? Becaus, I can´t reproduce this in Feast SDK Version: "feast 0.11.1.dev49+gbf557bcb".

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[dejavu284]

This issue is still relevant

[franciscojavierarceo]

Oh we'll take a look at this! Thanks for reopening @tokoko !

[meyudi]

Hello @dejavu284 I added, applied and then deleted an Entity with

feast version
Feast SDK Version: "0.1.dev3709+ge5527ad"

followed by

feast entities list
feast registry-dump

The deleted entity was not listed after deletion.

This issue is still relevant

Could you share how to reproduce the issue? Perhaps it was fixed recently.

[franciscojavierarceo]

@meyudi what version of feast are you using? That looks like a pretty old one.

[meyudi]

@franciscojavierarceo I am using

Feast SDK Version: "0.1.dev3709+ge5527ad"

[franciscojavierarceo]

are you building that from source? or are you pip installing it?

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.