feast-workshop icon indicating copy to clipboard operation
feast-workshop copied to clipboard

Module_0 not working due to changes in AWS bucket

Open pmayd opened this issue 2 years ago • 3 comments

It seems you no longer can attach ACL to buckets, see: https://github.com/terraform-aws-modules/terraform-aws-s3-bucket/issues/223. I removed the following resource from main.tf and was able to deploy

resource "aws_s3_bucket_acl" "feast_bucket_acl" {
  bucket = aws_s3_bucket.feast_bucket.bucket
  acl    = "private"
}

pmayd avatar Jul 06 '23 13:07 pmayd

found the same issue and resolved it by updating the main.tf file under infra/aws with the following lines

resource "aws_s3_bucket_ownership_controls" "feast_bucket_acl" {
  bucket = aws_s3_bucket.feast_bucket.bucket
  rule {
    object_ownership = "BucketOwnerPreferred"
  }
}

redhatHameed avatar Dec 11 '23 20:12 redhatHameed

good find @redhatHameed, thanks! Adding a small note that order is important, so the addition to main.tf needs to be above line 10 - this worked when I added to the top of the file underneath provider, but failed when I had just appended to bottom.

jeremyary avatar Dec 14 '23 15:12 jeremyary

@jeremyary agree here is PR to fix that https://github.com/feast-dev/feast-workshop/pull/19

redhatHameed avatar Dec 14 '23 15:12 redhatHameed