multi-git-status icon indicating copy to clipboard operation
multi-git-status copied to clipboard
verified publisher icon fboender

Lots of improvements

Open ceremcem opened this issue 5 years ago • 9 comments

  • Added tests
  • Added "stalled branch" detection
  • Added "only submodules" filter
  • Speedup
  • Covered "Repo has no commits yet" state

ceremcem avatar Jan 07 '21 20:01 ceremcem

Support for git submodules would be awesome! Great work, hope it can be incorporated into mgitstatus.

solarchemist avatar Mar 12 '21 21:03 solarchemist

Git submodules is a must-have! Thanks for adding this support.

However, I have 2 issues:

  1. It doesn't work on ZSH: git config --file=.gitmodules --get-regexp ^^submodule.*\.path$ | cut -d " " -f 2 (can be fixed by wrapping the regex in quotes: "^^submodule.*\.path$")
  2. It doesn't work on macOS: find -L "$DIR" $FIND_OPTS -depth -name ".git" -printf "%h\0" (no -printf flag on BSD's find)

It worked great on Bash/Linux; I'm hoping this can be resolved and merged soon.

Cheers!

braydentraas avatar Mar 15 '21 21:03 braydentraas

@braydentraas Does gfind solve the issue on Mac: https://superuser.com/a/293200/187576?

ceremcem avatar Mar 15 '21 21:03 ceremcem

@ceremcem Yes it does, but now readarray isn't available on mac/BSD either (or zsh even on linux)

braydentraas avatar Mar 15 '21 22:03 braydentraas

As I don't have Mac on hand, I'm not sure how to proceed here. Are you able to implement the necessary changes and test on Mac? (I even didn't know this repo has been supporting Mac)

ceremcem avatar Mar 15 '21 22:03 ceremcem

@ceremcem I've made a few changes and submitted a PR to your repo. Works for me now on MacOS/ZSH and Linux/Bash

Thanks again!

btraas avatar Mar 16 '21 22:03 btraas

Any idea why this is not yet merged?

andrejpan avatar Apr 08 '24 08:04 andrejpan

Don't know.

ceremcem avatar Apr 08 '24 11:04 ceremcem

@ceremcem thank you for your updates!

andrejpan avatar Apr 09 '24 05:04 andrejpan