favalex
Support installation of modbus CLI script under Windows
This pull request slightly modifies the source code tree structure (it turns the bin/modbus script into a modbus module) and updates the setup.py to enable installation under Linux and Windows.
Hi, thanks for your PR.
I'm not up to date with python best practices for packaging, do you know if setup.py is still supported? I meant to learn about the .toml configuration that if I understand correctly is the new way, but didn't have time yet. If setup.py is still supported I will merge this PR, otherwise maybe this is the opportunity to switch to .toml.
Hello,
You're welcome. I am not really strong on Python packaging either, but it seems that neither setuptools nor setup.py are deprecated. There is however a recommendation to call the setuptools cli in a different manner (through pip). See https://packaging.python.org/en/latest/discussions/setup-py-deprecated/ for more details.
Best regards Nicolas
Le ven. 23 août 2024 à 13:34, Gabriele Favalessa @.***> a écrit :
Hi, thanks for your PR.
I'm not up to date with python best practices for packaging, do you know if setup.py is still supported? I meant to learn about the .toml configuration that if I understand correctly is the new way, but didn't have time yet. If setup.py is still supported I will merge this PR, otherwise maybe this is the opportunity to switch to .toml.
— Reply to this email directly, view it on GitHub https://github.com/favalex/modbus-cli/pull/31#issuecomment-2306902542, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAY3G76NOW4JGYAPXWZUFULZS4M3HAVCNFSM6AAAAABM7WM2B2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBWHEYDENJUGI . You are receiving this because you authored the thread.Message ID: @.***>