faucet icon indicating copy to clipboard operation
faucet copied to clipboard

Fully deprecate acl_in

Open mab68 opened this issue 5 years ago • 1 comments

acl_in is hinted at being deprecated here https://github.com/faucetsdn/faucet/blob/f13396aaff9eb4b3f265c60b750a590e81fb09f0/tests/unit/faucet/test_config.py#L46 & here https://github.com/faucetsdn/faucet/blob/bbe3246a2a593876c5319efb0ed19222fc47c598/tests/unit/faucet/test_check_config.py#L56 But it is still considered valid. Maybe finally deprecate acl_in in 1.10.0?

mab68 avatar Mar 17 '20 04:03 mab68

Oooohhhh I remember this. We held a faucet hackathon at NZNOG 2018 and @rsanger wrote us a nice acls_in implementation and we totally forgot to remove acl_in.

+faucet 1.10.0

Reference: https://github.com/faucetsdn/faucet/commit/64cd24e7bddcbf12dc36adfce23c517d182805b0

gizmoguy avatar Mar 17 '20 04:03 gizmoguy