fluent-json-schema
fluent-json-schema copied to clipboard
fastify
replace deepmerge with @fastify/deepmerge
To verify that PR https://github.com/fastify/deepmerge/pull/5 for deepmerge works accordingly I tested it locally. To not redo the implementation again, I created this PR. My assumption is, that the next release of fastify/deepmerge will be 1.1.0.
As soon as the PR in deepmerge is merged, this code change should become valid.
Pull Request Test Coverage Report for Build 2629210654
- -1 of 17 (94.12%) changed or added relevant lines in 2 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-0.3%) to 99.293%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| src/utils.js | 15 | 16 | 93.75% |
| <!-- | Total: | 16 | 17 |
| Totals | |
|---|---|
| Change from base Build 2477356259: | -0.3% |
| Covered Lines: | 426 |
| Relevant Lines: | 427 |
💛 - Coveralls
Pull Request Test Coverage Report for Build 2888099398
- 17 of 17 (100.0%) changed or added relevant lines in 2 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.1%) to 99.717%
| Totals | |
|---|---|
| Change from base Build 2880043851: | 0.1% |
| Covered Lines: | 427 |
| Relevant Lines: | 427 |
💛 - Coveralls
I guess this PR was not merged because of the drop in the code coverage. Added unit tests, and got it back to 100%.
Can this be merged now?
