fastify-caching icon indicating copy to clipboard operation
fastify-caching copied to clipboard

fix(types): option privacy in Nodenext | Node16

Open Gehbt opened this issue 2 years ago • 6 comments

Relate commit #116

When use with typescript in compilerOptions: "module": "Node16" | "Nodenext", it will call the namespace fastifyCaching, that caused image and should use image

I don`t know why those tests-suits fail.

Checklist

Reproduction

Gehbt avatar Feb 17 '24 15:02 Gehbt

What is this fixing?

mcollina avatar Feb 17 '24 18:02 mcollina

What is this fixing?

I added the informations.

Gehbt avatar Feb 18 '24 10:02 Gehbt

Can you please add a test?

We use tsd

gurgunday avatar Feb 18 '24 11:02 gurgunday

Can you please add a test?

We use tsd

I cannot provide the test, but I can give a minimal reproduction.

Gehbt avatar Feb 18 '24 12:02 Gehbt

Do you review the Reproduction? I think I have revealed it: there is using "type": "commonjs", if changed to "type": "module" it will break. May we really ought to wait a guy in NodeNext?

Gehbt avatar Mar 04 '24 16:03 Gehbt

Not sure how we could test this... but reproducing is possible

gurgunday avatar Mar 04 '24 16:03 gurgunday

any chance of getting this merged?

marcoreni avatar Jun 27 '24 18:06 marcoreni