full-stack-fastapi-template icon indicating copy to clipboard operation
full-stack-fastapi-template copied to clipboard

🔥 Remove isort configuration, since we use Ruff now

Open patrick91 opened this issue 1 year ago • 1 comments

This PR removes the isort configuration from pyproject.toml

The configuration options we had set aren't supported by ruff just yet, but I think the default config is pretty much what we want (after all running ruff now didn't change anything).

I'm also removing the calls to isort, since we want to use ruff for this.

I've also update the format.sh script to use ruff, do we want to keep it?

patrick91 avatar Apr 02 '24 14:04 patrick91

@patrick91 format.sh can be removed, if you see lint.sh is doing what you wrote in format.sh and was called just by format-import.sh which was removed in your PR too

estebanx64 avatar Apr 03 '24 12:04 estebanx64

Great, thanks @patrick91! :rocket:


I restored format.sh with the updated commands, it's quite similar with lint.sh, but it's actually different, lint.sh only shows errors, doesn't modify the code, format.sh modifies the code.

tiangolo avatar Apr 05 '24 19:04 tiangolo