python-fakturoid icon indicating copy to clipboard operation
python-fakturoid copied to clipboard

Väčší počet objektov na stránku

Open alby-m opened this issue 2 years ago • 3 comments

Fakturoid zmenil počet objektov, ktorý vráti v rámci response (napr. z API endpointu invoices) z 20 na 40.

Trieda PagedResource ale počíta stále s 20 objektami, preto pri paginácii vracia len prvých 20 objektov z každej stránky a zvyšok odignoruje.

Pre fix by malo by stačiť upraviť paging.py

class PagedResource(object):
    """List adapter for paged resources. Returns sliceable lazy loaded object."""

    def __init__(self, page_size=40):
        self.pages = {}
        self.page_size = page_size or 40
        self.page_count = None

Vopred ďakujem za čo najrýchlejší fix :pray:

alby-m avatar Feb 15 '23 12:02 alby-m

Changed to 40 in my v3 fork - https://github.com/jan-tomek/python-fakturoid

Jan

jan-tomek avatar Feb 10 '25 08:02 jan-tomek

@jan-tomek Glad to hear about your v3 fork - I'll switch to it soon, re-apply all the improvements to this repo and open PRs if needed.

Just a suggestion relevant to the pagination fix. It seemed strange to me to have the page length fixed when it can be detected from the first page. Please see the fix in my fork: https://github.com/piit79/python-fakturoid/commit/336a7b256e0e3b28c9eb252e719971c9ef117959

piit79 avatar Feb 10 '25 09:02 piit79

Included in my fork.

jan-tomek avatar Feb 10 '25 17:02 jan-tomek