protocol icon indicating copy to clipboard operation
protocol copied to clipboard

fix: adds EIP1271 to supported signature type

Open parseb opened this issue 1 year ago • 1 comments

Adds EIP1271 signature type to signer registry graph

parseb avatar May 25 '24 13:05 parseb

What is the bug?

protocolBug

The Specification mentions only ECDSA signature support for managing signers. The validator calls the registry's verifyFidSignature which makes use of OpenZeppelin's SignatureChecker util which supports EIP1271 signature. As such, the signature is validated by the issuing smart contract and not by ECDSA recovery.

https://github.com/OpenZeppelin/openzeppelin-contracts/blob/e50c24f5839db17f46991478384bfda14acfb830/contracts/utils/cryptography/SignatureChecker.sol#L43

How can it be reproduced? (optional) Include steps, code samples, replits, screenshots and anything else that would be helpful to reproduce the problem.

Additional context (optional) Add any other context about the problem here.

parseb avatar May 25 '24 13:05 parseb