plugins icon indicating copy to clipboard operation
plugins copied to clipboard

[github plugin] split the field github.repo

Open Issif opened this issue 1 year ago • 4 comments

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area plugins

/area registry

/area build

/area documentation

What this PR does / why we need it:

Split the field github.repo into github.repo.name and github.repo.url

Which issue(s) this PR fixes:

#300

Fixes #

Special notes for your reviewer:

I didn't updated the changelog, when i use the function in the makefile, it breaks the file, what's the good way to process?

Issif avatar Sep 17 '24 15:09 Issif

Rules files suggestions

rules

Comparing 90955af7e5a4141f8c8f2b882449ec7cb5f7a8d9 with latest tag plugins/github/v0.7.5

Minor changes:

  • Version dependency to plugin github has been incremented

Patch changes:

  • Rule Private Repository Becoming Public changed its output fields
  • Rule Public Repository Becoming Private changed its output fields
  • Rule Create Public Repository changed its output fields
  • Rule Delete Public Repository changed its output fields
  • Rule Create Repository changed its output fields
  • Rule Delete Repository changed its output fields
  • Rule Create Deploy Key changed its output fields
  • Rule Delete Deploy Key changed its output fields
  • Rule Add Collaborator to Repository changed its output fields
  • Rule Remove Collaborator from Repository changed its output fields
  • Rule Secret pushed into a public repository changed its output fields
  • Rule Secret pushed into a private repository changed its output fields
  • Rule Github action with miners changed its output fields

github-actions[bot] avatar Sep 18 '24 12:09 github-actions[bot]

Rules files suggestions

rules

Comparing 546482a8b376519d63a9fa8b0eaf10a67315c35d with latest tag plugins/github/v0.7.5

Minor changes:

  • Version dependency to plugin github has been incremented

Patch changes:

  • Rule Private Repository Becoming Public changed its output fields
  • Rule Public Repository Becoming Private changed its output fields
  • Rule Create Public Repository changed its output fields
  • Rule Delete Public Repository changed its output fields
  • Rule Create Repository changed its output fields
  • Rule Delete Repository changed its output fields
  • Rule Create Deploy Key changed its output fields
  • Rule Delete Deploy Key changed its output fields
  • Rule Add Collaborator to Repository changed its output fields
  • Rule Remove Collaborator from Repository changed its output fields
  • Rule Secret pushed into a public repository changed its output fields
  • Rule Secret pushed into a private repository changed its output fields
  • Rule Github action with miners changed its output fields

github-actions[bot] avatar Sep 18 '24 12:09 github-actions[bot]

Rules files suggestions

rules

Comparing 2291564d8b0ddf27ffb57cf1ed323d02eabd73bd with latest tag plugins/github/v0.7.5

Minor changes:

  • Version dependency to plugin github has been incremented

Patch changes:

  • Rule Private Repository Becoming Public changed its output fields
  • Rule Public Repository Becoming Private changed its output fields
  • Rule Create Public Repository changed its output fields
  • Rule Delete Public Repository changed its output fields
  • Rule Create Repository changed its output fields
  • Rule Delete Repository changed its output fields
  • Rule Create Deploy Key changed its output fields
  • Rule Delete Deploy Key changed its output fields
  • Rule Add Collaborator to Repository changed its output fields
  • Rule Remove Collaborator from Repository changed its output fields
  • Rule Secret pushed into a public repository changed its output fields
  • Rule Secret pushed into a private repository changed its output fields
  • Rule Github action with miners changed its output fields

github-actions[bot] avatar Sep 18 '24 15:09 github-actions[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

poiana avatar Oct 02 '24 12:10 poiana

LGTM label has been added.

Git tree hash: 6077cf4478fab5e41cbb6f4608d5b9c7b37a03a4

poiana avatar Oct 02 '24 12:10 poiana