plugins icon indicating copy to clipboard operation
plugins copied to clipboard

fix(container): Propagate engine initialization errors to the caller

Open rabbitstack opened this issue 3 months ago • 4 comments

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area plugins

/area registry

/area build

/area documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

If the specific container engine worker fails during initialization, the error is silently skipped, making it hard to troubleshoot the real problem. Instead, accumulate and bubble up all the errors to the async handler.

Special notes for your reviewer:

rabbitstack avatar Oct 13 '25 12:10 rabbitstack

Rules files suggestions

github-actions[bot] avatar Oct 13 '25 13:10 github-actions[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rabbitstack Once this PR has been reviewed and has the lgtm label, please assign ekoops for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

poiana avatar Oct 13 '25 13:10 poiana

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rabbitstack Once this PR has been reviewed and has the lgtm label, please assign ekoops for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

poiana avatar Oct 13 '25 13:10 poiana

Rules files suggestions

github-actions[bot] avatar Oct 13 '25 13:10 github-actions[bot]