auracle icon indicating copy to clipboard operation
auracle copied to clipboard

doesn't compile with abseil-cpp 20200225.2 (not libalpm.so.13)

Open nycko123 opened this issue 4 years ago • 5 comments

Info:

  • latest git pacman 6.0.0.r0.g75eb3f4c-1
  • with libalpm.so.13

Symlinking libalpm.so.12 > libalpm.so.13 ends up with an error during compilation:

[89/134] Compiling C++ object subprojects/abs FAILED: subprojects/abseil-cpp-20200225.2/libabsl_synchronization_lib.a.p/absl_synchronization_internal_graphcycles.cc.o c++ -Isubprojects/abseil-cpp-20200225.2/libabsl_synchronization_lib.a.p -Isubprojects/abseil-cpp-20200225.2 -I../subprojects/abseil-cpp-20200225.2 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -std=c++17 -Wno-sign-compare -march=haswell -mtune=generic -O3 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2,-D_GLIBCXX_ASSERTIONS -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -fPIC -MD -MQ subprojects/abseil-cpp-20200225.2/libabsl_synchronization_lib.a.p/absl_synchronization_internal_graphcycles.cc.o -MF subprojects/abseil-cpp-20200225.2/libabsl_synchronization_lib.a.p/absl_synchronization_internal_graphcycles.cc.o.d -o subprojects/abseil-cpp-20200225.2/libabsl_synchronization_lib.a.p/absl_synchronization_internal_graphcycles.cc.o -c ../subprojects/abseil-cpp-20200225.2/absl/synchronization/internal/graphcycles.cc ../subprojects/abseil-cpp-20200225.2/absl/synchronization/internal/graphcycles.cc: In member function ‘void absl::lts_2020_02_25::synchronization_internal::GraphCycles::RemoveNode(void*)’: ../subprojects/abseil-cpp-20200225.2/absl/synchronization/internal/graphcycles.cc:451:26: error: ‘numeric_limits’ is not a member of ‘std’ 451 | if (x->version == std::numeric_limits<uint32_t>::max()) { | ^~~~~~~~~~~~~~ ../subprojects/abseil-cpp-20200225.2/absl/synchronization/internal/graphcycles.cc:451:49: error: expected primary-expression before ‘>’ token 451 | if (x->version == std::numeric_limits<uint32_t>::max()) { | ^ ../subprojects/abseil-cpp-20200225.2/absl/synchronization/internal/graphcycles.cc:451:52: error: ‘::max’ has not been declared; did you mean ‘std::max’? 451 | if (x->version == std::numeric_limits<uint32_t>::max()) { | ^~~ | std::max In file included from /usr/include/c++/11.1.0/algorithm:62, from ../subprojects/abseil-cpp-20200225.2/absl/synchronization/internal/graphcycles.cc:38: /usr/include/c++/11.1.0/bits/stl_algo.h:3467:5: note: ‘std::max’ declared here 3467 | max(initializer_list<_Tp> __l, _Compare __comp) | ^~~ [98/134] Compiling C++ object subprojects/abs....2/libabsl_flags_lib.a.p/absl_flags_flag.cc.o ninja: build stopped: subcommand failed.

nycko123 avatar May 20 '21 14:05 nycko123

Doesn't compile regardless of libalpm and pacman versions. Symlinking .so.12 to .so.13 works with already built and installed package (git version r366.8739929-1).

Some time ago it was possible to build the AUR package https://aur.archlinux.org/packages/auracle-git/ with no errors but not anymore.

nycko123 avatar May 20 '21 15:05 nycko123

It seems this is fixed here https://github.com/abseil/abseil-cpp/commit/5bf048b, so I think bumping the version in subprojects/abseil-cpp.wrap is the solution?

E5ten avatar May 20 '21 20:05 E5ten

Just updated the abseil-cpp wrap to latest LTS 20210324.1 upstream. With that as a subproject it builds OK.

inglor avatar May 24 '21 14:05 inglor

Latest abseil-cpp LTS fixes the issue. Wrap file in auracle/subprojects is still needed do fix the AUR package tho https://github.com/mesonbuild/abseil-cpp/releases/download/20210324.1-1/abseil-cpp.wrap as in #https://github.com/inglor/auracle/commit/bcd5ceef60bce3e463cc8a2c93f6750d6dd49f4e

nycko123 avatar May 25 '21 17:05 nycko123

Just updated the abseil-cpp wrap to latest LTS 20210324.1 upstream. With that as a subproject it builds OK.

Unfortunately it breaks the search function /usr/include/c++/11.1.0/string_view:234: constexpr const value_type& std::basic_string_view<_CharT, _Traits>::operator[](std::basic_string_view<_CharT, _Traits>::size_type) const [with _CharT = char; _Traits = std::char_traits<char>; std::basic_string_view<_CharT, _Traits>::const_reference = const char&; std::basic_string_view<_CharT, _Traits>::size_type = long unsigned int]: Assertion '__pos < this->_M_len' failed. zsh: abort (core dumped) auracle search vim

nycko123 avatar May 26 '21 10:05 nycko123